Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme: Supported Specification Features has broken links #320

Closed
lholmquist opened this issue Aug 18, 2020 · 1 comment · Fixed by #321 or #368
Closed

Readme: Supported Specification Features has broken links #320

lholmquist opened this issue Aug 18, 2020 · 1 comment · Fixed by #321 or #368
Labels
type/question Further information is requested

Comments

@lholmquist
Copy link
Contributor

Describe the Bug

If you were to click the v0.3 and v1.0 links on this table on the readme, https://github.com/cloudevents/sdk-javascript#supported-specification-features, they return a 404 since they don't link anywhere.

We could/should probably link out to the appropriate section in the spec repo.

I did notice however, that the spec repo only has a master and v1.0 branches, https://github.com/cloudevents/spec/branches/all so i'm not sure where to get the v0.3 spec links
@lholmquist lholmquist added the type/question Further information is requested label Aug 18, 2020
@lance
Copy link
Member

lance commented Aug 19, 2020

@lholmquist the v0.3 specs are just tagged https://github.com/cloudevents/spec/tree/v0.3

lholmquist added a commit to lholmquist/sdk-javascript that referenced this issue Aug 19, 2020
@lholmquist
chore(readme): fix support specification links.
7f130cf 
* This adds the real links to the v0.3 and v1.0 specification.

fixes cloudevents#320

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this issue Aug 19, 2020
Merged
lholmquist added a commit that referenced this issue Aug 19, 2020
@lholmquist
chore: Update README with correct links for the support specification…
73f0bec 
… versions (#321)

* chore(readme): Remove reference of HTTPReceiver

* chore(readme): fix support specification links.

* This adds the real links to the v0.3 and v1.0 specification.

fixes #320

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
lance pushed a commit that referenced this issue Sep 11, 2020
@lholmquist @lance
chore: Update README with correct links for the support specification…
198abb6 
… versions (#321)

* chore(readme): Remove reference of HTTPReceiver

* chore(readme): fix support specification links.

* This adds the real links to the v0.3 and v1.0 specification.

fixes #320

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this issue Oct 26, 2020
Closed
@lholmquist lholmquist mentioned this issue Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/question Further information is requested
Projects
None yet
Milestone
No milestone
2 participants
@lance @lholmquist