Inline Spec File #129
Merged
Inline Spec File #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loudevents#118) The Knative Kafka event source does not include a `Content-Type` header when sending binary events. The CE HTTP binding specification doesn't address how a receiver should handle this situation. This commit makes `application/json` the default. Fixes: cloudevents#117 Ref: cloudevents/spec#614 Signed-off-by: Lance Ball <lball@redhat.com> Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
lance
requested changes
May 6, 2020
There was a problem hiding this comment.
Inlining the spec file looks fine. I'm curious what you have in mind for more sophisticated methods for handling multiple versions.
It seems like you have inadvertently pulled in a commit that has already landed 5b747ee. Can you remove this from the PR?
… mode (cloudevents#118)" This reverts commit 9ccfaf2. Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
Great.
Yes, removed. |
lance
approved these changes
May 6, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR inlines the spec file and deletes the
extfolder. In the future, we can use a more sophisticated way of managing multiple spec versions.