fix: throw "no cloud event detected" if one can't be read #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helio-frota
requested changes
May 8, 2020
There was a problem hiding this comment.
It would be nice to have the simplified constants usage as done in this PR: #134
You mind to update the PR with that addition?
|
@helio-frota Good catch. I can do it now, or wait until #134 lands and update this PR from master (which is what I was planning to do). |
This commit changes the event mode detection in `HTTPReceiver` so that it will throw a TypeError if the event mode can't be detected per the spec. Signed-off-by: Lance Ball <lball@redhat.com>
lance
force-pushed
the
136-fix-receiver-event-sniffing
branch
from
e653ca5
to
7462d08
Compare
|
@helio-frota updated with simplified constants usage |
helio-frota
approved these changes
May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the event mode detection in
HTTPReceiverso that it willthrow a TypeError if the event mode can't be detected per the spec.
Fixes: #136
Signed-off-by: Lance Ball lball@redhat.com