Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: make HTTPEmitter headers method a property of the class #186

Merged
merged 1 commit into from
May 24, 2020
Merged

lib: make HTTPEmitter headers method a property of the class #186

merged 1 commit into from
May 24, 2020

Conversation

lance
Copy link
Member

@lance lance commented May 22, 2020

Now, instead of requiring an instance of HTTPEmitter to retrieve the headers
for an event, you can get them this way:

const headers = HTTPEmitter.headers(myCloudEvent);

Fixes: #178

@lance
lib: make HTTPEmitter headers method a property of the class
e6ab50a 
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested review from a team, danbev, grant and helio-frota and removed request for a team May 22, 2020 18:29
@lance lance self-assigned this May 22, 2020
@lance lance added the type/enhancement New feature or request label May 22, 2020
@lance lance merged commit f50e80f into cloudevents:master May 24, 2020
@lance lance deleted the 178-extract-headers branch May 24, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

@danbev danbev Awaiting requested review from danbev

@helio-frota helio-frota Awaiting requested review from helio-frota

Assignees

@lance lance

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a better way to extract headers from a CloudEvent
2 participants
@lance @grant