Skip to content

docs: generate api documentation as a GitHub workflow #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

docs: generate api documentation as a GitHub workflow #217

merged 1 commit into from
Jun 8, 2020

Conversation

lance
Copy link
Member

@lance lance commented Jun 8, 2020

Fixes: #212

@lance lance added the module/docs Module documentation changes label Jun 8, 2020
@lance lance requested a review from a team June 8, 2020 22:16
@lance lance self-assigned this Jun 8, 2020
@lance lance requested review from danbev, fabiojose and grant and removed request for a team June 8, 2020 22:16
@lance lance force-pushed the tsdoc-workflow branch from 87a9d90 to 21c2e6e Compare June 8, 2020 22:18
grant
grant approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I can't see a preview, but assuming it works, looks like an elegant solution to docs.

@lance
docs: generate api documentation as a GitHub workflow
94a35fe 
Fixes: cloudevents#212
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance force-pushed the tsdoc-workflow branch from 21c2e6e to 94a35fe Compare June 8, 2020 22:21
@lance
Copy link
Member Author

lance commented Jun 8, 2020

Preview: http://lanceball.com/sdk-javascript/

@lance lance merged commit 44b791b into cloudevents:master Jun 8, 2020
@lance lance mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danbev danbev Awaiting requested review from danbev

@fabiojose fabiojose Awaiting requested review from fabiojose

1 more reviewer

@grant grant grant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lance lance

Labels

module/docs Module documentation changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Publish SDK docs on gh_pages branch

2 participants

@lance @grant