Skip to content

fix: correct the spread order for http_emitter options #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: correct the spread order for http_emitter options #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5562a32
fix: correct the spread order for http_emitter options
lholmquist Jun 15, 2020
8619cd5
squash: add test
lholmquist Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/bindings/http/emitter_binary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class BinaryHTTPEmitter {
* @returns {Promise} Promise with an eventual response from the receiver
*/
async emit(options, cloudevent) {
const config = { ...options, ...defaults };
const config = { ...defaults, ...options };
const headers = config[HEADERS];

this.headerParserMap.forEach((parser, getterName) => {
Expand Down
11 changes: 11 additions & 0 deletions test-ts/http_emitter_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ describe("HTTP Transport Binding Emitter for CloudEvents", () => {
}).catch(expect.fail);
});

it("Sends a binary CloudEvent with Custom Headers", () => {
emitter.send(event, { headers: { customheader: "value" } }).then((response: { data: { [k: string]: string } }) => {
// A binary message will have a ce-id header
expect(response.data.headers.customheader).to.equal("value");
expect(response.data[BINARY_HEADERS_1.ID]).to.equal(event.id);
expect(response.data[BINARY_HEADERS_1.SPEC_VERSION]).to.equal(SPEC_V1);
// A binary message will have a request body for the data
expect(response.data.lunchBreak).to.equal(data.lunchBreak);
}).catch(expect.fail);
});

it("Provides the HTTP headers for a binary event", () => {
const headers = HTTPEmitter.headers(event);
expect(headers[BINARY_HEADERS_1.TYPE]).to.equal(event.type);
Expand Down