Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: combine all parsers into a single file #269

Merged
merged 2 commits into from
Jul 24, 2020
Merged

refactor: combine all parsers into a single file #269

merged 2 commits into from
Jul 24, 2020

Conversation

grant
Copy link
Member

@grant grant commented Jul 23, 2020

Simplifies the parser files.
No logic changes.

grant and others added 2 commits July 23, 2020 11:46
@grant
Merge pull request #1 from cloudevents/master
145775b 
Merge
@grant
refactor: simplify parser logic and duplicated code
6a66337 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from lance July 23, 2020 23:07
@grant grant self-assigned this Jul 23, 2020
@lance lance changed the title refactor: simplify the parser logic refactor: combine all parsers into a single file Jul 24, 2020
@lance lance added the chore/refactor Refactoring and other non-functional changes to module code label Jul 24, 2020
@lance lance mentioned this pull request Jul 24, 2020
Closed
@lholmquist lholmquist merged commit a6124cc into cloudevents:master Jul 24, 2020
@grant grant deleted the grant_parser branch July 24, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@lance lance lance approved these changes

Assignees

@grant grant

Labels
chore/refactor Refactoring and other non-functional changes to module code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grant @lance @lholmquist