Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix promise tests to break the build when they fail #305

Merged
merged 4 commits into from
Aug 7, 2020
Merged

chore: fix promise tests to break the build when they fail #305

merged 4 commits into from
Aug 7, 2020

Commits on Aug 6, 2020

  1. squash: return the promise that is being tested 

    Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
    @lholmquist
    lholmquist committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    af8f0af View commit details
    Browse the repository at this point in the history

  2. squash: fix linting issues 

    Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
    @lholmquist
    lholmquist committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    69ed797 View commit details
    Browse the repository at this point in the history

  3. squash: fail to prove the point 

    Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
    @lholmquist
    lholmquist committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    d7a2d9d View commit details
    Browse the repository at this point in the history

  4. squash: fix test, now that the point was proven 

    Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
    @lholmquist
    lholmquist committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    95b43ad View commit details
    Browse the repository at this point in the history