Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not alter an event's data attribute #344

Merged
merged 4 commits into from
Oct 6, 2020
Merged

fix: do not alter an event's data attribute #344

merged 4 commits into from
Oct 6, 2020

Commits on Sep 28, 2020

  1. fix: do not alter an event's data attribute 

    When setting an event's data attribute we were trying to be really clever
and this is problematic. Instead, keep the data attribute unchanged. Per
the 1.0 specification, the data attribute is still inspected to determine
if it is binary, and if so, a data_base64 attribute is added with the
contents of the data property encoded as base64.

Fixes: cloudevents#343

Signed-off-by: Lance Ball <lball@redhat.com>
    @lance
    lance committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    db40de9 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. fix: ensure that received binary data remains binary in an event 

    Unless... its datacontenttype is application/json. In that case it
should be converted into an object.

Signed-off-by: Lance Ball <lball@redhat.com>
    @lance
    lance committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    624fc79 View commit details
    Browse the repository at this point in the history

  2. fixup: remove stray old comment 

    Signed-off-by: Lance Ball <lball@redhat.com>
    @lance
    lance committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    5255a19 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. fixup: do not parse binary data even as application/json 

    Signed-off-by: Lance Ball <lball@redhat.com>
    @lance
    lance committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    4407a0b View commit details
    Browse the repository at this point in the history