Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tag v3.2.0 as release-v3.2.0 for release-please #353

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

lance
Copy link
Member

@lance lance commented Oct 15, 2020

Description

Pin the release-v3.2.0 branch at the point where we branched off of main to create that release. I think this should do what we want. PTAL @bcoe.

Signed-off-by: Lance Ball lball@redhat.com

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added the chore/actions Changes or additions to GitHub Workflow actions label Oct 15, 2020
@lance lance requested a review from a team October 15, 2020 19:25
@lance lance self-assigned this Oct 15, 2020
@lance
Copy link
Member Author

lance commented Oct 15, 2020

@bcoe do you recommend closing the existing v1.0.0 PR from release-please?

@bcoe
Copy link

bcoe commented Oct 16, 2020

@lance yeah, I'd close it out and remove the autorelease: pending label. Then let's merge this and I'm here to help if there are issues for the next few hours, will keep eye on inbox.

Edit: also, if you do bump into any additional issues, I'll do my best to make sure we patch your use case by Monday.

@lance lance merged commit 765b81c into cloudevents:main Oct 16, 2020
@lance
Copy link
Member Author

lance commented Oct 16, 2020

Edit: also, if you do bump into any additional issues, I'll do my best to make sure we patch your use case by Monday.

Thanks for that offer @bcoe. I will be taking PTO tomorrow and Monday, so @lholmquist can pick this up, or... we can just wait until Tuesday. I appreciate your help - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore/actions Changes or additions to GitHub Workflow actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants