-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated API transition guide. #363
Deprecated API transition guide. #363
Conversation
86059d3
to
ad1659c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of small nits. Outside of that, we'll need to adjust this for #366. Overall, lgtm. Thanks - this was needed!
c352047
to
9298f2e
Compare
ef1d74a
to
ef31b68
Compare
@lance mind give this another look see. If things are good, i will squash and fix that DCO error before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @lholmquist!
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
ef31b68
to
2e7db49
Compare
This adds a guide to show the transition of the deprecated API's of 3.2.0 .
We can also use this for future deprecations
Description
fixes #360