Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

540 fix node version #541

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

sskular-wonderlab
Copy link
Contributor

Proposed Changes

Update Node version to 20.0.0

Description

Fixes: #540

dependabot bot and others added 2 commits March 15, 2023 11:10
Bumps [webpack](https://github.com/webpack/webpack) from 5.75.0 to 5.76.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.75.0...v5.76.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Slavko Skular <slavko.skular@wonderlab-it.co.uk>
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance lance merged commit 1cf8f8a into cloudevents:main May 2, 2023
@sskular-wonderlab sskular-wonderlab deleted the 540-fix-node-version branch May 10, 2023 14:44
@@ -158,6 +158,6 @@
},
"types": "./dist/index.d.ts",
"engines": {
"node": ">=12 <20.0.0"
"node": ">=12 <=20.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to change it to <=20
Otherwise you say it's only working on 20.0.0, but not in 20.1.0 and 20.2.0, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - that was addressed in #545

"node": ">=16 <=20.0.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now... gotcha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error when installing on node 20.0.0
3 participants