Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: use string instead of enum for Version #561

Merged
merged 1 commit into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. BREAKING CHANGE: use string instead of enum for Version

    TypeScript does not consider enum values equivalent, even if the string
    representation is the same. So, when a module imports `cloudevents` and
    also has a dependency on `cloudevents` this can cause conflicts where
    the `CloudEvent.version` attribute is not considered equal when, in
    fact, it is.
    
    Changing the `enum` to a string is pretty straightforward, but should be
    considered a breaking change since TypeScript dependents will
    potentially fail the build with a change like this.
    
    Signed-off-by: Lance Ball <lball@redhat.com>
    lance committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    1ccce9f View commit details
    Browse the repository at this point in the history