Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null context attributes in json #142

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

slinkydeveloper
Copy link
Member

Fix #125. Per spec, these fields are ignored and handled as missing.

Signed-off-by: Francesco Guardiani francescoguard@gmail.com

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@slinkydeveloper slinkydeveloper added the bug Something isn't working label Jul 7, 2021
@slinkydeveloper slinkydeveloper added this to the 0.4 milestone Jul 7, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Copy link
Contributor

@jcrossley3 jcrossley3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@slinkydeveloper slinkydeveloper merged commit bcb8363 into cloudevents:master Jul 7, 2021
@slinkydeveloper slinkydeveloper deleted the issues/125 branch July 7, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Serialization bug?
2 participants