Skip to content

Implementing an Iterator for the Attributes struct #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 57 commits into from
Apr 30, 2020
Merged

Implementing an Iterator for the Attributes struct #26

merged 57 commits into from
Apr 30, 2020

Conversation

pranav-bhatt
Copy link
Contributor

@pranav-bhatt pranav-bhatt commented Apr 16, 2020 •
edited
Loading

This pull request is meant to implement the Iterator trait on the Attributes struct. It returns an Option<(&str, AttributeValue)> value. The Iterator will skip over any None values encountered in the non-essential fields.

slinkydeveloper
slinkydeveloper reviewed Apr 16, 2020
View reviewed changes
slinkydeveloper
slinkydeveloper reviewed Apr 16, 2020
View reviewed changes
@slinkydeveloper
Copy link
Member

slinkydeveloper commented Apr 16, 2020 •
edited
Loading

when you commit, you need to signoff commits with --signoff. the DCO bot should tell you how to sign all the previous ones.

@slinkydeveloper
Copy link
Member

So now we need the same for attributes struct in v03

@slinkydeveloper
Copy link
Member

Also, every time you commit, don't forget to run cargo fmt

slinkydeveloper and others added 7 commits April 29, 2020 19:54
@slinkydeveloper @pranav-bhatt
Reworked try_get_data (cloudevents#17)
cc99f21 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @pranav-bhatt
Added CONTRIBUTING.md (cloudevents#19)
8e1547c 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @Lazzaretti @pranav-bhatt
Serde (cloudevents#18)
ed27147 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

Co-authored-by: Fabrizio Lazzaretti <fabrizio@lazzaretti.me>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
just to align with other sdks (cloudevents#21)
8b95873 
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
add link to email (cloudevents#22)
fe20dca 
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @pranav-bhatt
WIP iter attributes
b889cb4 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
adding iterator to v10/attributes (WIP)
1f6f886 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
slinkydeveloper reviewed Apr 29, 2020
View reviewed changes
src/event/v10/attributes.rs Outdated

#[test]
fn iterator_test(){
let a = Attributes{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declare as mut

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so even if I do declare as mut, when it gets passed to .into_iter(), it will get initialised to 0 each time, and wont move ahead!

@slinkydeveloper
Copy link
Member

That's good! Now you need to do the same on the v03 attributes

pranav-bhatt and others added 15 commits April 29, 2020 19:59
@pranav-bhatt
rebasing upstream
846d377 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Completed Iterator
d698cb5 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @pranav-bhatt
Implemented custom deserialization process
f5cd2bc 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @pranav-bhatt
Implemented custom serialization process
5e26781 
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @pranav-bhatt
V0.3 implementation (cloudevents#24)
f7cca69 
* Added String variant to Data

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Started V0.3 work

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reworked EventDeserializer trait

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Now event parsing works with v1 and changes

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Cargo fmt

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reorganized test data

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fixed serde for v03

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Implemented spec version conversion

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* cargo fmt

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Correcting errors
d8a0966 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
roll back
33813d6 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper @pranav-bhatt
WIP iter attributes
28d1148 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Completed Iterator for v10/attribute
c60a5cc 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Error fix 2
426316f 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Error fix 2
38e0325 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Completed iterator
757e03e 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Update attributes.rs
dacf625 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Optimised Code cloudevents#1
fd9ba4c 
Resolved:
1. https://github.com/cloudevents/sdk-rust/pull/26/files#r409586754
2. https://github.com/cloudevents/sdk-rust/pull/26/files#r409585595

Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Added Test in v10/attributes
d316616 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Error fix 2
11c9748 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Completed iterator
142c811 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Update attributes.rs
3a6ab08 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Optimised Code cloudevents#1
cd3a545 
Resolved:
1. https://github.com/cloudevents/sdk-rust/pull/26/files#r409586754
2. https://github.com/cloudevents/sdk-rust/pull/26/files#r409585595

Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Added Test in v10/attributes
fcda5ed 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Ran cargo fmt
ddfb103 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Added iterator to AttributeV03
d1bda4a 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
updated .gitignore for /target
ff2b6e4 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
updated .gitignore
b8434a6 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Deleting incorrect EOL files
8c5761b 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Rebased and updated types in iterator
12e4ae4 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
Rebased and updated types in iterator
d096fb3 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
minor bug fixes
dcb2f00 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
modified URI and URIRef
16e3b10 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
cargo fmt
efcd54b 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper
Copy link
Member

You wrongly remove CONTRIBUTING and README in this pr

@pranav-bhatt pranav-bhatt marked this pull request as ready for review April 30, 2020 12:22
@slinkydeveloper slinkydeveloper marked this pull request as ready for review April 30, 2020 12:25
slinkydeveloper
slinkydeveloper requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@slinkydeveloper slinkydeveloper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the removal of Contributing.md and readme.md with

git fetch upstream
git checkout upstream/master -- CONTRIBUTING.md
git checkout upstream/master -- README.md

(assuming you named this remote with upstream)

@slinkydeveloper
Copy link
Member

Please revert also the .gitignore

@pranav-bhatt
fixed CONTRIBUTING, README and .gitignore
f203e52 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
slinkydeveloper
slinkydeveloper requested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@slinkydeveloper slinkydeveloper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some minor changes needed

@pranav-bhatt
URI->URIRef in iterator
e52b220 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
URI->URIRef for iterator 2
fd09bb8 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@pranav-bhatt
minor bug fixes
16ab4a1 
Signed-off-by: Pranav Bhatt <adpranavb2000@gmail.com>
@slinkydeveloper slinkydeveloper merged commit 304a2e7 into cloudevents:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slinkydeveloper slinkydeveloper slinkydeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pranav-bhatt @slinkydeveloper