Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook-Allowed-Origin instead of Webhook-Request-Origin #673

Closed
schabungbam opened this issue Jul 22, 2020 · 4 comments
Closed

Webhook-Allowed-Origin instead of Webhook-Request-Origin #673

schabungbam opened this issue Jul 22, 2020 · 4 comments

Comments

@schabungbam
Copy link

For the webook, http-webhook.md - in the example of using a wildcard for the validation response, do we mean Webhook-Allowed-Origin instead of Webhook-Request-Origin?
@deissnerk
Copy link
Contributor

I think you are right. 😃
Do you want to create a PR for this?

@duglin
Copy link
Collaborator

duglin commented Jul 22, 2020

ping @clemensv ^^

@duglin
Copy link
Collaborator

duglin commented Jun 17, 2021

On 6/17 call, @deissnerk said he'd open a PR for this.

@deissnerk deissnerk mentioned this issue Jun 25, 2021
Merged
duglin pushed a commit that referenced this issue Jul 5, 2021
Merge pull request #836 from deissnerk/webhook-fix
c812a2e 
Fix for #673 - WebHook-Allowed-Origin
@duglin
Copy link
Collaborator

duglin commented Jul 21, 2021

#673 addressed this one - so closing.
Not sure why github didn't close it.

@duglin duglin closed this as completed Jul 21, 2021
sunshengjing added a commit to sunshengjing/spec that referenced this issue Apr 27, 2022
@sunshengjing
docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudeven…
2f3cceb 
…ts#673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>
sunshengjing added a commit to sunshengjing/spec that referenced this issue Apr 27, 2022
@sunshengjing
docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudeven…
72f931e 
…ts#673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>
sunshengjing added a commit to sunshengjing/spec that referenced this issue Apr 27, 2022
@sunshengjing
docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudeven…
6d6a58c 
…ts#673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>
sunshengjing added a commit to sunshengjing/spec that referenced this issue Apr 28, 2022
@sunshengjing
docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudeven…
16ad9f3 
…ts#673:fix bad hyper-link [#occurrence]

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>
duglin pushed a commit that referenced this issue Apr 28, 2022
@sunshengjing
docs:update languages/zh-CN/spec.md(#982) (#1001)
69dfe0d 
* docs:update languages/zh-CN/spec.md(#982)
Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(#982)
Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(#982) #1001

Signed-off-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>

* add back two understores spec.md

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(#982) verify #673:fix bad hyper-link [#occurrence]

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

Co-authored-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>
duglin pushed a commit that referenced this issue May 3, 2022
@sunshengjing
Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982
0284b8c 
 (#1003)

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982

Signed-off-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982 #1003

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(#982) verify #673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(#982) verify #673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(#982) verify #673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982#1003: add spaces before/after the -

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982 verify #679:fix bad link 'occurrence'

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982 verify #679:fix bad link 'occurrence'

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN #982 verify #679:fix bad link 'creating-cloudevents'

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

Co-authored-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>
clemensv pushed a commit to clemensv/spec that referenced this issue Aug 19, 2022
@sunshengjing
docs:update languages/zh-CN/spec.md(cloudevents#982) (cloudevents#1001)
36898b2 
* docs:update languages/zh-CN/spec.md(cloudevents#982)
Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(cloudevents#982)
Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(cloudevents#982) cloudevents#1001

Signed-off-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>

* add back two understores spec.md

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudevents#673:fix bad hyper-link [#occurrence]

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

Co-authored-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>
clemensv pushed a commit to clemensv/spec that referenced this issue Aug 19, 2022
@sunshengjing
Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN c…
b363db5 
…loudevents#982 (cloudevents#1003)

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN cloudevents#982

Signed-off-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN cloudevents#982 cloudevents#1003

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudevents#673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudevents#673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* docs:update languages/zh-CN/spec.md(cloudevents#982) verify cloudevents#673

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN cloudevents#982#1003: add spaces before/after the -

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN cloudevents#982 verify cloudevents#679:fix bad link 'occurrence'

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN cloudevents#982 verify cloudevents#679:fix bad link 'occurrence'

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

* Translate cloudevents/spec/blob/main/cloudevents/primer.md to zh-CN cloudevents#982 verify cloudevents#679:fix bad link 'creating-cloudevents'

Signed-off-by: Shengjing SUN <sunshengjing@gmail.com>

Co-authored-by: Sun Shengjing <sunshengjing@Suns-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duglin @schabungbam @deissnerk