Clarify boolean literals in specification #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
reviewed
Nov 25, 2023
cesql/spec.md
Outdated
| @@ -117,7 +117,7 @@ CESQL defines 3 different literal kinds: integer numbers, `true` or `false` bool | |||
| digit ::= [0-9] | |||
| number-literal ::= digit+ | |||
|
|
|||
| boolean-literal ::= "true" | "false" | |||
| boolean-literal ::= "true" | "false" | "TRUE" | "FALSE" | |||
There was a problem hiding this comment.
Is there a format that means "any case", so that TrUe would be acceptable too?
There was a problem hiding this comment.
@MaryamTaj I couldn't find a way... can you add a comment to indicate that it's case insensitive?
e.g.
boolean-literal ::= "true" | "false" (* Case insensitive *)
There was a problem hiding this comment.
@MaryamTaj we chatted about this on today's call... are you ok with the above suggestion?
There was a problem hiding this comment.
@duglin Thank you so much for letting me know! I'd be happy to make the changes:)
There was a problem hiding this comment.
So just to check, this is intended to match True and False (or, less likely, tRUE and fALSE)? I'm pretty sure that's the aim, just checking.
Signed-off-by: MaryamTaj <tajm48822@gmail.com>
|
LGTM |
|
Approved on the 12/7 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1232
Proposed Changes
Include "TRUE" | "FALSE" when you define boolean literals in the spec.md
Release Note