Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to CESQL tck test cases #1255

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Cali0707
Copy link
Contributor

@Cali0707 Cali0707 commented Feb 1, 2024

While running the tck tests, I noticed that there were a few mistakes in them. This PR aims to fix those.

Proposed Changes

  • Fix typo of expresion -> expression
  • Fix result of a test case that was incorrectly set to true
  • Change CE overrides for another test to make sure that it returns an error, rather than depending on the SDK not optimizing AND evaluation for the error to occur

Signed-off-by: Calum Murray <cmurray@redhat.com>
@duglin
Copy link
Collaborator

duglin commented Feb 1, 2024

/LGTM

@duglin
Copy link
Collaborator

duglin commented Feb 8, 2024

Approved on the 2/8 call

@duglin duglin merged commit 3ff0462 into cloudevents:main Feb 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants