-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Attribute Categories section #139
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -194,6 +194,31 @@ concurrently, including being both a producer and a consumer of events. | |
For this, the framework will need a suitable metadata discriminator | ||
that frees it from having to understand the event details. | ||
|
||
## Attribute Categories | ||
|
||
The number of metadata attributes will be constrained to the minimal set needed | ||
to achieve the stated goals. To that end, attributes defined by this | ||
specification will fall into three categories: | ||
- required | ||
- optional | ||
- extensions | ||
|
||
As the category names imply, "required" attributes will be the ones that are | ||
considered vital to all events in all use cases, while "optional" ones will be | ||
used in a majority of use cases. If an attribute is not common enough to fall | ||
into those two categories but would still benefit from the level of | ||
interoperability that comes from being well-defined, then it will be placed into | ||
the "extensions" category and described in the (extensions)[extensions.md] | ||
document. The spec will define how these extension attributes will appear within | ||
a CloudEvent. | ||
|
||
Core attributes, whether required or optional, are those that describe the event | ||
itself. For example those attributes may relate to the source, the content type, | ||
the time the event occurred, or any identifying information. Attributes that are | ||
relevant only for certain contexts within which the event may be used will be in | ||
the extensions category. Examples might include grouping, sampling, correlation, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure I take for granted that these are extensions cases, and if they were they should certainly be registered extensions. These are all cases where multiple parts of a distributed stack need to interoperate to work correctly. |
||
and tracing. | ||
|
||
## Status | ||
At this time the specification is focused on the following scope: | ||
|
||
|
@@ -399,4 +424,3 @@ that contains both context and data). | |
serverless function which listens on the source event, opens a connection to | ||
the destination protocol and maps every incoming event (received through | ||
event API) to an event message over the destination protocol. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we seem to be dividing extensions into two categories as well:
This concept was taken directly from the JWT spec where private claims may be registered claims.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true - I guess originally I was thinking that we'd just talk about the stuff that might appear in our docs, but you're right, we should mention that people can do "other extensions" that this WG has no knowledge of.