Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NATS transport binding #215

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

ColinSullivan1
Copy link
Contributor

I'd like to propose a NATS transport binding for CloudEvents, similar to the HTTP binding and proposed MQTT and AMQP bindings. This PR borrows heavily from the MQTT proposal.

Signed-off-by: Colin Sullivan colin@synadia.com

@sslavic
Copy link
Contributor

sslavic commented May 25, 2018

@ColinSullivan1 please rebase the PR/branch.
#216 got merged and there's now trivial conflict to be resolved.

@ColinSullivan1
Copy link
Contributor Author

@sslavic , thanks for the heads up, I've rebased.

@sslavic
Copy link
Contributor

sslavic commented May 28, 2018

@ColinSullivan1 just please list the NATS transport binding in readme.md https://github.com/cloudevents/spec#cloudevents-documents

Other than that, LGTM.

@ColinSullivan1
Copy link
Contributor Author

@sslavic - Thanks, I'll add that. Just confirming, do I set v0.1 as latest release? I notice this PR has a v0.1 label.

@sslavic
Copy link
Contributor

sslavic commented May 29, 2018

It has v1.0 label, not 0.1. Latter was released some time ago and documents available at that time were listed/tagged.

IMO for NATS transport binding document just master/draft reference would be enough for now. Later when next release is made, references for the documents in the release would be updated.

@ColinSullivan1
Copy link
Contributor Author

Thanks @sslavic .

@duglin
Copy link
Collaborator

duglin commented May 29, 2018

CI/href failure is real but expected/ok until PR is merged.

@alexellis
Copy link

Good to see this @ColinSullivan1, looks like the Makefile needs a rebase though.

@duglin
Copy link
Collaborator

duglin commented Jun 7, 2018

I think the rebase is off a bit

@ColinSullivan1
Copy link
Contributor Author

Yes, sorry, will fix.

Signed-off-by: Colin Sullivan <colin@synadia.com>
@duglin duglin merged commit 0fe6fd5 into cloudevents:master Jun 7, 2018
@duglin
Copy link
Collaborator

duglin commented Jun 7, 2018

Approved on 6/7 call

@longit644 longit644 mentioned this pull request Sep 1, 2018
@duglin duglin mentioned this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants