-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some additional design points for ID #403
Conversation
spec.md
Outdated
* Examples: | ||
* A database commit ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted to replay transactions from a database, you would want to use the commit ID in the cloudevent, otherwise you do not have a method for detecting duplicated events and the ID in the context the cloudevent is irrelevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think commit ID is a valid choice for some cases, however, if that DB commit results in more than one event then it's not a good choice. So, I wanted to avoid getting into those nuances in this section and decided to leave that for the primer. I think UUID is a more clear example.
Given our recent discussions around source and ID, I think this one can be reexamined since I think it's consistent with where we landed. |
I made a few very minor changes to this today just to better align with the new definitions of source and producer from @deissnerk. I don't think it changed anything substantial - just made the split between source and producer a bit more clear. I'd like to see if we can resolve this one on today's call - so please give it a review and comment. I did a force-push by mistake, so here's the diff of the edits I made for those who want to see just those:
|
Signed-off-by: Doug Davis <dug@us.ibm.com>
Signed-off-by: Doug Davis <dug@us.ibm.com>
Approved on the 5/30 call - with the agreement to make it clear that sources are identified by their CE I updated the text per Evan's suggestion on the call yesterday. PTAL. |
LGTM. Looks good. There are some interesting implications of this, I think. Anything that causes two events with the same |
thanks @evankanderson |
Signed-off-by: Doug Davis dug@us.ibm.com