Master represents the future version of the spec, use the future version in the text. #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Nichols <nicholss@google.com>
|
@n3wscott we talked about this on this week's call and there was agreement to change the version to something other than 0.2 but 0.3 didn't seem appropriate since it's not 0.3 yet. The group seemed to like |
|
Yeah I can make that update! That works for me.
…On Sat, Apr 13, 2019, 7:00 PM Doug Davis ***@***.***> wrote:
@n3wscott <https://github.com/n3wscott> we talked about this on this
week's call and there was agreement to change the version to something
other than 0.2 but 0.3 didn't seem appropriate since it's not 0.3 yet. The
group seemed to like 0.3.wip - you ok with that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#415 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Aezx8NbgB5bxOBNRSPwTKQg99VUg1tnEks5vgouvgaJpZM4ck5u4>
.
|
Signed-off-by: Scott Nichols <nicholss@google.com>
|
thanks! |
duglin
reviewed
Apr 15, 2019
roadmap.md
Outdated
| @@ -55,7 +55,7 @@ _0.2_ - Completed - 2018/12/06 | |||
| 1. Define the set of protocol and serialization mappings we're going to produce | |||
| for 0.4 milestone | |||
|
|
|||
| _0.3_ | |||
| _0.3-wip_ | |||
There was a problem hiding this comment.
I think this one needs to be skipped
|
LGTM |
|
Approved on the 4/18 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change bumps the version used in master to
0.3-wipof the spec.This becomes very clear (and confusing) when you are reading the examples of features are are only in
0.3-wip, like Batch support.Signed-off-by: Scott Nichols nicholss@google.com