Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/schemaurl/dataschema/ to be consistent #475

Merged
merged 2 commits into from
Aug 15, 2019
Merged

s/schemaurl/dataschema/ to be consistent #475

merged 2 commits into from
Aug 15, 2019

Conversation

duglin
Copy link
Collaborator

@duglin duglin commented Jul 31, 2019 •
edited
Loading

Let's discuss. But I tend to think it's better to get this right
for v1.0 than to continue to be inconsistent and let a pre-v1.0
version dictate things forever.

Closes #474

Signed-off-by: Doug Davis dug@us.ibm.com

@duglin duglin added the v1.0 label Jul 31, 2019
@duglin
Copy link
Collaborator Author

duglin commented Aug 6, 2019

On last week's call we briefly discussed this and "someone" mentioned that they thought the schemaurl pointed to the schema of the entire CloudEvent, not just data. That's part of the reason I want to make this change. Many people will not know (or read) the CE spec like we do and so we need to pick names that are as clear as possible for those who don't.

If you have an opinion on this (for or against) please speak up here or on the call this week. I'd like to resolve this issue (one way or the other) if we can.

@duglin duglin changed the title s/schemaurl/dataschemaurl/ to be consistent s/schemaurl/dataschema/ to be consistent Aug 8, 2019
@duglin
Copy link
Collaborator Author

duglin commented Aug 8, 2019

Per today's call I:

  • changed the attribute to: “dataschema”
  • made it a URI
  • Add URI to type section

@deissnerk deissnerk mentioned this pull request Aug 14, 2019
Merged
n3wscott
n3wscott reviewed Aug 15, 2019
View reviewed changes
SDK.md Outdated
@@ -128,7 +128,7 @@ Here's the list of getters:
Source() -> URL
EventID() -> string
EventTime() -> RFC3339
SchemaURL() -> string
DataSchema() -> string
Copy link
Member

@n3wscott n3wscott Aug 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> URL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - I'll pick up this change - if someone thinks it's incorrect we can open another PR and revert it. @clemensv @markpeek @fabiojose @deissnerk

Doug Davis added 2 commits August 15, 2019 17:27
s/schemaurl/dataschemaurl/ to be consistent
7ebf0f9 
Let's discuss. But I tend to think it's better to get this right
for v1.0 than to continue to be inconsistent and let a pre-v1.0
version dictate things forever.

Signed-off-by: Doug Davis <dug@us.ibm.com>
per today's call
fc54ad1 
Signed-off-by: Doug Davis <dug@us.ibm.com>
@duglin
Copy link
Collaborator Author

duglin commented Aug 15, 2019

Approved on the 8/15 call

@duglin duglin merged commit decc935 into cloudevents:master Aug 15, 2019
@duglin duglin deleted the issue474 branch August 15, 2019 18:08
@duglin duglin mentioned this pull request Sep 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott left review comments

Assignees
No one assigned
Labels
v1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

schemaurl -> dataschemaurl ?
2 participants
@duglin @n3wscott