Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distributed tracing example. #569

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Feb 19, 2020

Per https://w3c.github.io/trace-context/#value, tracestate values must
not contain (,) or (=) characters.

Signed-off-by: Ian Milligan ianmllgn@gmail.com

Per https://w3c.github.io/trace-context/#value, tracestate values must
not contain (,) or (=) characters.

Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
@duglin
Copy link
Collaborator

duglin commented Feb 19, 2020

LGTM thanks!
Can I get one more set of eyes just to make sure... then I'll merge.

@duglin
Copy link
Collaborator

duglin commented Mar 2, 2020

Approved on the 2/27 call

@duglin duglin merged commit d0490a9 into cloudevents:master Mar 2, 2020
@duglin duglin mentioned this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants