Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery add history #868

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Conversation

erikerikson
Copy link
Member

Fixes #699

Proposed Changes

  • Add discovery endpoint as a Service entity by which it publishes changes to itself
  • Add historical querying capability (perhaps better delivered by allowing subscriptions to specify delivery of events starting from those available as of a time in the past)

Release Note

Add Discovery Endpoint as a "self" Service Entity
Add historical service change query endpoint 

Signed-off-by: Erik Erikson <erik.erikson@gmail.com>
Signed-off-by: Erik Erikson <erik.erikson@gmail.com>
Signed-off-by: Erik Erikson <erik.erikson@gmail.com>
application/json:
schema:
$ref: '#/components/schemas/serviceinstance'
$ref: '#/components/requestBodies/servicedeleterequest'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a requestBody on a delete is discouraged by OpenAPI for reasons discussed here. To abusively summarize the most useful piece, there is no standard about the interaction of HTTP DELETEs on to resource collections and the caching layers which may cause undesirable lack of caching on one hand and/or a use of cached resources inappropriately on the other.

e.g.

DELETE /services

[
  { id: {id_0} },
  ...
  { id: {id_N} },
]

Does not clear /services/{id_0} from HTTP response caches which, unless configured not to cache, are allowed to cache and return that value following the resource's deletion using a DELETE with a request body.

ce_discovery.yaml Outdated Show resolved Hide resolved
discovery.md Outdated Show resolved Hide resolved
As suggested and discussed, removing the changes path (i.e. HTTP history
endpoint) in preference for subscriptions offering a read offset
configuration.

Signed-off-by: Erik Erikson <erik.erikson@gmail.com>
@erikerikson
Copy link
Member Author

@duglin this has been pending the AIs from Clemens and Klaus but I am wondering if we expect those to alter this in some way? If not, we might be able to merge this and proceed by altering it as necessary?

Signed-off-by: Erik Erikson <erik.erikson@gmail.com>
Signed-off-by: Erik Erikson <erik.erikson@gmail.com>
@duglin
Copy link
Collaborator

duglin commented Oct 19, 2021

Approved on the 10/14 call

@duglin duglin merged commit 86e52fa into cloudevents:master Oct 19, 2021
@erikerikson erikerikson deleted the discovery-add-history branch October 19, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants