Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# namespace option to proto #937

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Jan 18, 2022

The naming choice is based on the C# SDK core being
"CloudNative.CloudEvents". This creates a bias towards using the C#
SDK instead of "roll-your-own" - but I think that's okay,
personally. Happy to consider other options.

Proposed Changes

  • Add a C# namespace option to cloudevents.proto

Release Note

Adds a C# namespace option of `CloudNative.CloudEvents.V1` to the proto representation.

@jskeet
Copy link
Contributor Author

jskeet commented Jan 18, 2022

Note: this is against the main branch. I've lost the plot in terms of what we're doing in which branch at the moment. I believe I've got an action item to propose an alternative, but...

The naming choice is based on the C# SDK core being
"CloudNative.CloudEvents". This creates a bias towards using the C#
SDK instead of "roll-your-own" - but I think that's okay,
personally. Happy to consider other options.

Signed-off-by: Jon Skeet <jonskeet@google.com>
@duglin
Copy link
Collaborator

duglin commented Jan 20, 2022

Approved on the 1/20 call

@duglin duglin merged commit b2b0541 into cloudevents:main Jan 20, 2022
@jskeet jskeet deleted the csharpnamespace branch January 20, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants