Skip to content

Conversation

@threepointone
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

🦋 Changeset detected

Latest commit: 6cacb5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
agents Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link

claude bot commented Nov 7, 2025

Claude Code Review

PR Summary: Dependency updates across the monorepo, including @AI-SDK packages (anthropic, google, openai, react), @cloudflare packages (vite-plugin, vitest-pool-workers, workers-types), @openai/agents, biome, wrangler, and various supporting libraries.

Issues Found:

  1. MCP SDK patch requires verification (patches/@modelcontextprotocol+sdk+1.21.0.patch:9-10)

    • The patch modifies the Ajv import from named to default import to fix vitest issues
    • This workaround should be validated: does @modelcontextprotocol/sdk@1.21.0 actually fix the underlying issue, or are we patching over a problem?
    • Consider opening an issue with the MCP SDK if this is a real bug
  2. Missing dependency version alignments

    • packages/agents/package.json updates to @ai-sdk/openai: 2.0.64 and ai: 5.0.89
    • These versions should be tested together as the ai SDK and provider packages are tightly coupled
    • The PR diff shows these were updated in root package.json dev deps but are production deps in packages/agents

Testing Coverage:

  • No test changes in this PR (expected for dependency updates)
  • Recommend running full test suite to catch any breaking changes
  • Pay attention to the vitest-related changes given the Ajv import patch

Verdict: Approve pending verification that:

  1. All tests pass with the new dependency versions
  2. The Ajv import patch is a legitimate workaround and not masking a deeper issue

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/cloudflare/agents@641

commit: 6cacb5a

@@ -0,0 +1,13 @@
diff --git a/node_modules/@modelcontextprotocol/sdk/dist/esm/validation/ajv-provider.js b/node_modules/@modelcontextprotocol/sdk/dist/esm/validation/ajv-provider.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hate having to do this, but this will be fixed after we land modelcontextprotocol/typescript-sdk#1065

@threepointone threepointone merged commit b2187b4 into main Nov 7, 2025
6 of 7 checks passed
@threepointone threepointone deleted the update-deps branch November 7, 2025 12:16
@threepointone threepointone mentioned this pull request Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant