-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for turnstile_widget #563
Add support for turnstile_widget #563
Conversation
029dd23
to
f61c3c4
Compare
ddfc1f2
to
931e327
Compare
thanks for the PR @punkeel. i ripped a bunch of this out as it looks like you were having an issue with determing the ID of a resource which we've solved in other places using (this)[https://github.com//pull/563/files#diff-c8a271423d325a18f64e8eb426bae4c393315dfd1fbc9bad21916c9eead1647aR948-R950] pattern. i've given this a run through and everything still looks to be working but can you eyeball it to make sure you're happy with this one as well? |
Your changes LGTM, thanks! 🙏 |
- `ListTurnstileWidgets` performs the pagination for us. - The API doesn't return an 'id' field, change `jsonStructData` directly to "spoof" it.
931e327
to
318698a
Compare
if err != nil { | ||
log.Fatal(err) | ||
} | ||
for i := 0; i < len(jsonStructData); i++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the ID hack here
nice, thanks! |
Tested with
cloudflare/terraform-provider-cloudflare@master
+cloudflare-go@master
: