Sort items before write #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgirouard
approved these changes
Jul 18, 2023
tamas-jozsa
approved these changes
Jul 18, 2023
jafowler
force-pushed
the
sort-items-before-write
branch
2 times, most recently
from
4668024 to
7c89532
Compare
| @@ -9,7 +9,7 @@ resource "cloudflare_zone_settings_override" "terraform_managed_resource" { | |||
| browser_check = "on" | |||
| cache_level = "aggressive" | |||
| challenge_ttl = 2700 | |||
| ciphers = ["ECDHE-RSA-AES128-GCM-SHA256", "AES128-SHA"] | |||
There was a problem hiding this comment.
i don't think we can blindly sort these as they are in the order at which they should be offered iirc.
There was a problem hiding this comment.
ACK, I will remove the logic that does this then. It will make things difficult / we might see some false positives in comparisons, but it should be alright i think.
jafowler
force-pushed
the
sort-items-before-write
branch
from
7c89532 to
546f3c2
Compare
jacobbednarz
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working through some issues with Version Compare, we noticed that Rulesets doesn't return phases in a specific order.
This PR will sort Rulesets by phases.