hpke: fix encapsulation seed in test for xyber #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwesterb
force-pushed
the
bas/fix-xyber-encseed
branch
from
b1b1fb7 to
12881a6
Compare
bwesterb
changed the title
bwesterb
force-pushed
the
bas/fix-xyber-encseed
branch
3 times, most recently
from
5e6485a to
9995e98
Compare
chris-wood
reviewed
Apr 14, 2023
Comment on lines
+392
to
+395
| if rnd2.Len() != 0 { | ||
| t.Fatal() | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| if rnd2.Len() != 0 { | |
| t.Fatal() | |
| } |
It doesn't seem like this is needed since we always create it as 64 bytes up above?
There was a problem hiding this comment.
This is defensive programming, to make sure we don't have a mismatch between the amount of randomness in the buffer and the actual amount consumed. It's not necessary now, but it might be once we check the upstream test vectors and copy-paste this code.
Instead of providing an ephemeral keypair for test vectors, for which Kyber does not have an analogue, we provide the encapsulation seed.
bwesterb
force-pushed
the
bas/fix-xyber-encseed
branch
from
9995e98 to
04b188f
Compare
chris-wood
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of providing an ephemeral keypair for test vectors,
for which Kyber does not have an analogue, we provide the encapsulation seed.