tss/rsa: Adding verification of signature shares #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbis9051
reviewed
Jul 20, 2023
jbis9051
reviewed
Jul 20, 2023
| // they are not verifiable. | ||
| // This field is present only if the RSA private key is | ||
| // composed of two safe primes. | ||
| vk *VerifyKeys |
There was a problem hiding this comment.
This should be added to the MarshalBinary/UnmarshalBinary functions https://github.com/cloudflare/circl/blob/tssRSAverif/tss/rsa/keyshare.go#L51
There was a problem hiding this comment.
to ease review, I will propose changes to the serialization functions in a different PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables verification of signature shares, provided safe primes are used in the RSA key.
Reference: Protocol 1 of https://www.iacr.org/archive/eurocrypt2000/1807/18070209-new.pdf
Stacked on top of #451