ML-DSA: Add preliminary Wycheproof test vectors #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a requirement of the ML-DSA standard. For Dilithium we'll keep accepting signatures with extra bytes.
bwesterb
force-pushed
the
bas/mldsa-wycheproof
branch
2 times, most recently
from
8324172 to
b3e4640
Compare
armfazh
approved these changes
Jul 14, 2025
Contributor
armfazh
left a comment
armfazh
left a comment
There was a problem hiding this comment.
looks good, nice addition of the hex type, as is used in other tests.
bwesterb
force-pushed
the
bas/mldsa-wycheproof
branch
from
b3e4640 to
155bc02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.