Skip to content

group: add byteLen method for short groups and RandomScalar uses rand.Int #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
armfazh merged 1 commit into from
Aug 22, 2025
Merged

group: add byteLen method for short groups and RandomScalar uses rand.Int #568

armfazh merged 1 commit into from
Aug 22, 2025
+51 −56

Conversation

@armfazh
Copy link
Contributor

@armfazh armfazh commented Aug 21, 2025

Changes:

  • add a byteLen method, reduces duplicated code
  • RandomScalar uses rand.Int, instead of calling to hashToField
  • Implement CSelect as two calls to CMov

@armfazh armfazh added the enhancement Improvement over something already in the project label Aug 21, 2025
@armfazh armfazh merged commit 7eb9f00 into main Aug 22, 2025
11 checks passed
@armfazh armfazh deleted the shortbyteLen branch August 22, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwesterb bwesterb bwesterb approved these changes

@lukevalenta lukevalenta Awaiting requested review from lukevalenta

Assignees

No one assigned

Labels

enhancement Improvement over something already in the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@armfazh @bwesterb