Revert to using package-declared HPKE errors for shortkem instead of standard library errors #578
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…standard library errors
bwesterb
approved these changes
Dec 19, 2025
armfazh
approved these changes
Dec 19, 2025
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit to update HPKE code to use ecdh stdlib package: 342ad81 - changed the error returned from the Unmarshal functions from
shortkemto return the underlying error (which returns the standard library errors). Consideringxkemstill returns the package defined errors and if the project doesn't need the underlying error for some reasons, it would make sense to keep the error returned consistent and also helps projects handle errors better.