Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workers Next.js guide to work on @opennextjs/cloudflare@0.3.x #18946

Open
wants to merge 2 commits into
base: production
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Dec 27, 2024

Summary

fixes #18936

This PR updates the outdated Next.js workers guide so that it can properly work with @opennextjs/cloudflare@0.3.x
(similarly to cloudflare/workers-sdk#7638)

Screenshots (optional)

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.

Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d0aa567
Status: ✅  Deploy successful!
Preview URL: https://22c0752b.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://dario-next-experimental-open.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The c3 template has not yet been updated for 0.3. however the ON version is not pin to 0.2.x in the last c3 release (I submited a PR that got merged after the last release).

I'm not sure what's the best time to merge this PR. Either now or once the c3 template is updated.

I'll let you decide

@dario-piotrowicz
Copy link
Member Author

LGTM

The c3 template has not yet been updated for 0.3. however the ON version is not pin to 0.2.x in the last c3 release (I submited a PR that got merged after the last release).

I'm not sure what's the best time to merge this PR. Either now or once the c3 template is updated.

I'll let you decide

Thanks 🙂

The part of the guide I've updated is under Existing Next.js apps so it is actually unrelated to C3, so I would say the sooner we merge this the better 🙂 (I linked this PR with the workers-sdk one just because those are loosely related)

So I'd just wait for a PCX review and then merge 🙂

@dario-piotrowicz
Copy link
Member Author

dario-piotrowicz commented Dec 27, 2024

@vicb the video tutorial is also outdated... we should probably do something about that too... I think we can either put a warning callout there saying that it is slightly outdated and maybe also point out what changed since the video was made or remove the video tutorial completely.

By far I prefer the latter as the former feels very unpolished and more costly to maintain to me, what do you think? do you have a preference here?

@dario-piotrowicz
Copy link
Member Author

@megaconfidence as mentioned above (and discussed with Vic offline) we're removing your video tutorial, sorry about that 😓, maybe we can work together to get an updated version of it up? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js framework guide for worker is outdated and does not work.
7 participants