-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update workers Next.js guide to work on @opennextjs/cloudflare@0.3.x
#18946
base: production
Are you sure you want to change the base?
Conversation
Deploying cloudflare-docs with Cloudflare Pages
|
Files with changes (up to 15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The c3 template has not yet been updated for 0.3. however the ON version is not pin to 0.2.x in the last c3 release (I submited a PR that got merged after the last release).
I'm not sure what's the best time to merge this PR. Either now or once the c3 template is updated.
I'll let you decide
Thanks 🙂 The part of the guide I've updated is under So I'd just wait for a PCX review and then merge 🙂 |
@vicb the video tutorial is also outdated... we should probably do something about that too... I think we can either put a warning callout there saying that it is slightly outdated and maybe also point out what changed since the video was made or remove the video tutorial completely. By far I prefer the latter as the former feels very unpolished and more costly to maintain to me, what do you think? do you have a preference here? |
…e@0.3.x` remove outdated video tutorial
@megaconfidence as mentioned above (and discussed with Vic offline) we're removing your video tutorial, sorry about that 😓, maybe we can work together to get an updated version of it up? 😄 |
Summary
fixes #18936
This PR updates the outdated Next.js workers guide so that it can properly work with
@opennextjs/cloudflare@0.3.x
(similarly to cloudflare/workers-sdk#7638)
Screenshots (optional)
Documentation checklist