Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workers] Clarify compatibility_date in wrangler.toml #16519

Closed
wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Aug 29, 2024

Summary

Clarify what happens when compatibility_date is not specified in wrangler.toml

Documentation checklist

Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npx wrangler deploy
✘ [ERROR] A compatibility_date is required when publishing. Add the following to your wrangler.toml file:.

      ```
      compatibility_date = "2024-08-28"
      ```

?

@vicb
Copy link
Contributor Author

vicb commented Aug 29, 2024

Oh!

Let me double check then. At least this is inconsistent with dev:

▲ [WARNING] No compatibility_date was specified. Using the installed Workers runtime's latest supported date: 2024-08-21.

  ❯❯ Add one to your wrangler.toml file: compatibility_date = "2024-08-21", or
  ❯❯ Pass it in your terminal: wrangler dev [<SCRIPT>] --compatibility-date=2024-08-21
  
  See https://developers.cloudflare.com/workers/platform/compatibility-dates/ for more information.

@vicb
Copy link
Contributor Author

vicb commented Aug 29, 2024

@irvinebroque I'm going to close this.

What are your thinking about the misalignment of dev vs prod here?
Looks like the behavior has been consistent since it was implemented.
However I can not think of any benefit of having different behaviors in dev vs deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants