Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thomasgauvin: add docs for hyperdrive to connect to private databases #16766
thomasgauvin: add docs for hyperdrive to connect to private databases #16766
Changes from 5 commits
c25b01e
32e2dcf
c0c9d3b
4a2bfab
158ba97
c1101a0
33f3938
85fd095
30e1b52
78a6006
1ed0078
02edd73
bd4eb43
e81cae6
c606302
22eeea6
5029a3d
eba7b41
313ba57
1204dcf
1a57155
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is that these instructions become obsolete if ZT changes their dashboard experience... Maybe it would be better to point at their documentation for this? But that would also fragment the experience of this walkthrough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to re-use as much as possible. The issue lies in the fact that we need to provide opinionated guidance for some of these. For instance, we need to indicate that they need to specify Type TCP and something such as localhost:5432 when creating the tunnel.
Here, we need to specify the service auth token that needs to be configured.