-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code from service worker to module worker format #17905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, 3 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We updated our inline suggestion AI.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
...content/docs/cloudflare-for-platforms/cloudflare-for-saas/domain-support/custom-metadata.mdx
Show resolved
Hide resolved
...content/docs/cloudflare-for-platforms/cloudflare-for-saas/domain-support/custom-metadata.mdx
Show resolved
Hide resolved
...content/docs/cloudflare-for-platforms/cloudflare-for-saas/domain-support/custom-metadata.mdx
Show resolved
Hide resolved
Let's use |
...content/docs/cloudflare-for-platforms/cloudflare-for-saas/domain-support/custom-metadata.mdx
Show resolved
Hide resolved
...content/docs/cloudflare-for-platforms/cloudflare-for-saas/domain-support/custom-metadata.mdx
Show resolved
Hide resolved
...content/docs/cloudflare-for-platforms/cloudflare-for-saas/domain-support/custom-metadata.mdx
Show resolved
Hide resolved
As discuss we Brendan, I updated the PR to always use async fetch(request, env, ctx): Promise<Response> even if |
@ToriLindsay @dcpena - can we get ✅ to merge this? |
@vicb Approved. Thanks! |
Thanks for the review and merge! |
Summary
Update code from service worker to module worker format
Documentation checklist
Question:
I have added only the used parameters
The full signature is
Specifying only the used parameters is valid syntax.
Are there guidelines to prefer one over the other syntax?
My plan is to convert most example to using the new syntax as the old syntax is deprecated. I'll send more PR after this one gets in.