[Ruleset Engine] Use Type component in fields reference #18070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
src/content/docs/ruleset-engine/rules-language/fields/http-request-header.mdx
Show resolved
Hide resolved
src/content/docs/ruleset-engine/rules-language/fields/standard-fields.mdx
Show resolved
Hide resolved
Deploying cloudflare-docs with
|
| Latest commit: |
6fb2e66
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://84b800eb.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://pedro-2024-11-08-ruleset-eng.cloudflare-docs-7ou.pages.dev |
Oxyjun
reviewed
Nov 8, 2024
| | `text/html+extra` | `"text/html+extra"` | | ||
| | `text/html+extra; charset=utf-8` | `"text/html+extra"` | | ||
| | `text/HTML` | `"text/html"` | | ||
| | `text/html; charset=utf-8; other=value` | `"text/html"` | | ||
|
|
||
| </Details> | ||
|
|
||
| ## `cf.response.1xxx_code` |
There was a problem hiding this comment.
Suggested change
| ## `cf.response.1xxx_code` | |
| ## `cf.response.1xxx_code` |
Do these need to be capitalised as well (in light of the below changes)
There was a problem hiding this comment.
No, not here, since the field name is in lowercase.
Oxyjun
reviewed
Nov 8, 2024
|
|
||
| The raw IP packet as a list of bytes. It should be used in conjunction with the bit_slice function when other structured fields are lacking. | ||
|
|
||
| --- | ||
|
|
||
| ## `ip.dst` | ||
|
|
||
| `ip.dst` `IP Address` | ||
| `ip.dst` <Type text='IP address' /> |
There was a problem hiding this comment.
Suggested change
| `ip.dst` <Type text='IP address' /> | |
| `ip.dst` <Type text='IP address' /> |
More out of curiosity - is IP address a valid type?
There was a problem hiding this comment.
In the Rules language yes.
Oxyjun
approved these changes
Nov 8, 2024
pedrosousa
deleted the
pedro/2024-11-08-ruleset-engine-use-type-component-in-fields-reference
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.