TUN-3510: Argo Tunnel docs now use ingress rules (not CLI) to configure origins #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchalmers
requested review from
TownLake,
chungthuang,
ipostelnik and
sssilver
TownLake
reviewed
Nov 9, 2020
| disableChunkedEncoding: true | ||
| ``` | ||
| Remember you can [validate](/routing-to-tunnel/ingress#validating-your-configuration) and [test](/routing-to-tunnel/ingress#testing-your-configuration) |
Contributor
There was a problem hiding this comment.
Could remove "Remember" and start "You can" for users who have not reviewed that section yet.
TownLake
reviewed
Nov 9, 2020
TownLake
reviewed
Nov 9, 2020
| The example ingress rules above always proxied traffic to a HTTP service running on localhost. But `cloudflared` supports | ||
| other options too, including SSH, RDP, arbitrary TCP services, and unix sockets. You can also route traffic to the | ||
| built-in Hello World test server, or configure cloudflared to just respond with 404. |
Contributor
There was a problem hiding this comment.
missing tic marks: cloudflared
adamchalmers
force-pushed
the
achalmers/TUN-3510-multi-origin-docs-redux
branch
from
2cdfc0e to
d3c86f0
Compare
abracchi-tw
suggested changes
Nov 10, 2020
Contributor
abracchi-tw
left a comment
abracchi-tw
left a comment
There was a problem hiding this comment.
left some comments. @adamchalmers let me know what you think
adamchalmers
force-pushed
the
achalmers/TUN-3510-multi-origin-docs-redux
branch
from
00695fb to
28ff599
Compare
abracchi-tw
approved these changes
Nov 10, 2020
ingress rules. CLI args moved into a legacy page.
adamchalmers
force-pushed
the
achalmers/TUN-3510-multi-origin-docs-redux
branch
from
28ff599 to
deff8ab
Compare
Deploying with
|
| Latest commit: |
ac7bda2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d36369c2.cloudflare-docs-7ou.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs now tell users to configure the local services running on their origin via Ingress Rules, not via the CLI. I've added a new page explaining how ingress rules work, and another new page with all the various ingress rule config options.
Origin-related CLI arguments have been moved into their own page and marked as legacy. This PR should not result in any broken links.