Skip to content

Conversation

@rita3ko
Copy link
Collaborator

@rita3ko rita3ko commented Nov 10, 2020

No description provided.

@rita3ko rita3ko added the product:workers Related to Workers product label Nov 10, 2020
@rita3ko rita3ko requested a review from a team as a code owner November 10, 2020 16:21
@adamschwartz adamschwartz merged commit fbe2991 into production Nov 11, 2020
@adamschwartz adamschwartz deleted the rita/fix-workers-quickstart branch November 11, 2020 16:52
agents-git-bot bot pushed a commit that referenced this pull request Dec 2, 2025
Sync changes from cloudflare/sandbox-sdk PR #267:
- Add onOutput, onExit, onStart, and onError callbacks to startProcess()
- Document callback-based monitoring as preferred pattern
- Show accumulated logs pattern for fast commands
- Update API reference with complete ProcessOptions parameters

Fixes documented:
- Process callbacks now work (onOutput/onExit previously never fired)
- PID field now properly populated (was always undefined)
- getLogs() race condition fixed for fast commands

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
agents-git-bot bot pushed a commit that referenced this pull request Dec 3, 2025
Updates documentation to reflect bug fixes in sandbox-sdk PR #267:
- Add onStart, onOutput, onExit, and onError callback documentation
- Clarify that PID is now reliably available in process responses
- Document that getProcessLogs() now correctly captures output from fast commands
- Add guidance on when to use callbacks vs polling for process monitoring

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

product:workers Related to Workers product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants