Skip to content

Commit

Permalink
Add ID to CertificatePackAdvancedCertificate (#522)
Browse files Browse the repository at this point in the history
* Add `ID` to `CertificatePackAdvancedCertificate`

This wasn't intentionally required however for
cloudflare/terraform-provider-cloudflare#778 to work , this is now.
  • Loading branch information
jacobbednarz authored Aug 27, 2020
1 parent e708974 commit 38003bd
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions certificate_packs.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ type CertificatePackRequest struct {
// CertificatePackAdvancedCertificate is the structure of the advanced
// certificate pack certificate.
type CertificatePackAdvancedCertificate struct {
ID string `json:"id"`
Type string `json:"type"`
Hosts []string `json:"hosts"`
ValidationMethod string `json:"validation_method"`
Expand Down
2 changes: 2 additions & 0 deletions certificate_packs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ func TestCreateAdvancedCertificatePack(t *testing.T) {
mux.HandleFunc("/zones/023e105f4ecef8ad9ca31a8372d0c353/ssl/certificate_packs/order", handler)

certificate := CertificatePackAdvancedCertificate{
ID: "3822ff90-ea29-44df-9e55-21300bb9419b",
Type: "advanced",
Hosts: []string{"example.com", "*.example.com", "www.example.com"},
ValidityDays: 365,
Expand Down Expand Up @@ -278,6 +279,7 @@ func TestRestartAdvancedCertificateValidation(t *testing.T) {
mux.HandleFunc("/zones/023e105f4ecef8ad9ca31a8372d0c353/ssl/certificate_packs/3822ff90-ea29-44df-9e55-21300bb9419b", handler)

certificate := CertificatePackAdvancedCertificate{
ID: "3822ff90-ea29-44df-9e55-21300bb9419b",
Type: "advanced",
Hosts: []string{"example.com", "*.example.com", "www.example.com"},
ValidityDays: 365,
Expand Down

3 comments on commit 38003bd

@emiemmm5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

51011197628

@emiemmm5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

51011197628

@emiemmm5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.