-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose raw api call with context and raw context with headers #1068
Conversation
changelog detected ✅ |
I think that due to relatively niche usage of .Raw, this change doesn't necessarily warrant a changelog entry. Added a temporary one though. |
given the low usage of this method, i would probably just update the method signature to include |
I agree and having just 1 signature for this is enough as long as it's not as limiting as the current one. For some it may be a backwards incompatible change though. But I guess it doesnt really matter for that kind of method. Updated PR |
Codecov Report
@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 49.94% 50.04% +0.09%
==========================================
Files 115 116 +1
Lines 10991 11047 +56
==========================================
+ Hits 5490 5528 +38
- Misses 4338 4350 +12
- Partials 1163 1169 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This functionality has been released in v0.49.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Simple change, .Raw() is already exposed so it makes sense to also expose version with context and with headers. Possibly also full context+headers+complete version should be included.
Types of changes
What sort of change does your code introduce/modify?
Checklist: