Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed_match_count to DLP profiles #1193

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

pierreca
Copy link
Contributor

Adds the allowed_match_count field to DLP Profiles structure

Description

This is a new feature that the DLP team has shipped and is now generally available.

Has your change been tested?

The tests have been modified accordingly

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2023

changelog detected ✅

.changelog/1193.txt Outdated Show resolved Hide resolved
@jacobbednarz
Copy link
Member

i can see the public docs are already in the pipeline so happy to merge this one 👍

@jacobbednarz jacobbednarz merged commit 4e5b73b into cloudflare:master Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1193 (c07adfc) into master (6153c1e) will decrease coverage by 0.05%.
The diff coverage is 49.79%.

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
- Coverage   49.40%   49.36%   -0.05%     
==========================================
  Files         127      128       +1     
  Lines       12290    12430     +140     
==========================================
+ Hits         6072     6136      +64     
- Misses       4840     4890      +50     
- Partials     1378     1404      +26     
Impacted Files Coverage Δ
access_organization.go 64.70% <ø> (ø)
cloudflare.go 68.08% <0.00%> (-0.63%) ⬇️
cloudflare_experimental.go 0.00% <0.00%> (ø)
dlp_profile.go 37.93% <ø> (ø)
magic_transit_ipsec_tunnel.go 46.15% <ø> (ø)
rulesets.go 35.09% <ø> (ø)
teams_rules.go 44.94% <0.00%> (-0.52%) ⬇️
utils.go 72.72% <ø> (ø)
mtls_certificates.go 26.59% <26.59%> (ø)
workers_bindings.go 67.44% <40.00%> (-2.31%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added this to the v0.60.0 milestone Jan 30, 2023
github-actions bot pushed a commit that referenced this pull request Jan 30, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.60.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants