Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource_container: add explicit Type field for ResourceContainer #1325

Merged

Conversation

jacobbednarz
Copy link
Member

Extend the resource container object to have an explicit Type instead of inferring/manipulating from the Level.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #1325 (b9ac804) into master (74e0b34) will decrease coverage by 0.62%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master    #1325      +/-   ##
==========================================
- Coverage   48.95%   48.33%   -0.62%     
==========================================
  Files         135      133       -2     
  Lines       13180    13023     -157     
==========================================
- Hits         6452     6295     -157     
+ Misses       5212     5201      -11     
- Partials     1516     1527      +11     
Impacted Files Coverage Δ
access_audit_log.go 79.31% <0.00%> (ø)
device_posture_rule.go 61.80% <ø> (ø)
options.go 61.01% <ø> (-3.05%) ⬇️
teams_devices.go 52.63% <ø> (ø)
dns_firewall.go 7.69% <10.00%> (-13.74%) ⬇️
images.go 44.81% <46.06%> (-5.54%) ⬇️
tunnel.go 42.41% <66.66%> (+1.01%) ⬆️
access_policy.go 70.27% <73.33%> (-6.05%) ⬇️
access_application.go 72.72% <75.47%> (-3.80%) ⬇️
access_mutual_tls_certificates.go 68.86% <75.51%> (-3.36%) ⬇️
... and 9 more

... and 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

changelog detected ✅

@jacobbednarz jacobbednarz force-pushed the add-type-for-resource-container branch 2 times, most recently from 0610f24 to 9db5094 Compare July 5, 2023 02:33
Extend the resource container object to have an explicit `Type` instead of inferring/manipulating from the `Level`.
@jacobbednarz jacobbednarz force-pushed the add-type-for-resource-container branch from 9db5094 to b9ac804 Compare July 5, 2023 02:35
@jacobbednarz jacobbednarz reopened this Jul 5, 2023
@jacobbednarz jacobbednarz merged commit 191147b into cloudflare:master Jul 5, 2023
@jacobbednarz jacobbednarz deleted the add-type-for-resource-container branch July 5, 2023 02:37
@github-actions github-actions bot added this to the v0.72.0 milestone Jul 5, 2023
github-actions bot pushed a commit that referenced this pull request Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This functionality has been released in v0.72.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants