Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correlate (nat support) to rate limiting #208

Merged
merged 5 commits into from
Jul 26, 2018

Conversation

AshleyPoole
Copy link

Add correlate (nat support) to rate limiting so that the property can be configured.

I have another PR to add this to the Terraform Cloudflare provider.

@AshleyPoole
Copy link
Author

@patryk would you be able to give this a glance over and merge if happy? Also, how do I go about updating the package version or is this handled by the build definition?

@AshleyPoole
Copy link
Author

This PR is to resolve issue 212 (#212)

@patryk patryk merged commit a011a83 into cloudflare:master Jul 26, 2018
@patryk
Copy link

patryk commented Jul 26, 2018

Hey @AshleyPoole. Looks good, merged. Sorry for the delay.

As for Terraform provider, we need to update /vendor subdirectory in https://github.com/terraform-providers/terraform-provider-cloudflare/tree/master/vendor with govendor. I can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants