Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new API Tokens (beta) auth scheme #326

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Add support for the new API Tokens (beta) auth scheme #326

merged 3 commits into from
Jul 15, 2019

Conversation

hunts
Copy link
Contributor

@hunts hunts commented Jul 12, 2019

Description

API Tokens provide a new way to authenticate with the Cloudflare API. They allow for scoped and permissioned access to resources. This pull request added support for using it. An example and necessary introduction will be added to README by a follow up pull request once the open beta is announced.

Has your change been tested?

Tests a request send from the api client instantiated via NewWithAPIToken() contains the expected "Authorization" header.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@patryk
Copy link
Contributor

patryk commented Jul 12, 2019

cc: @jacobbednarz

Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We've been running a patch similar to this to use with Terraform provider for the closed beta so big 💯 to landing this and getting it into the provider 🙇

@patryk patryk merged commit 4809f66 into cloudflare:master Jul 15, 2019
@patryk
Copy link
Contributor

patryk commented Jul 15, 2019

\o/

Michael9127 pushed a commit to Michael9127/cloudflare-go that referenced this pull request Oct 28, 2019
* Add support for the new API Tokens auth scheme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants