Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ssl add opts #327

Merged
merged 4 commits into from
Jul 18, 2019
Merged

Custom ssl add opts #327

merged 4 commits into from
Jul 18, 2019

Conversation

jterzis
Copy link
Contributor

@jterzis jterzis commented Jul 17, 2019

Description

Rightsized ssl client to include new fields represented in api: geo_restrictions, type.
See api docs for resource : https://api.cloudflare.com/#custom-ssl-for-a-zone-create-ssl-configuration

Has your change been tested?

Tested against updated tests in ssl_test.go. For example, go test -v -run TestCreateSSL

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jterzis jterzis merged commit b59d4f0 into cloudflare:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants