Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for worker bindings #363

Merged
merged 4 commits into from
Oct 24, 2019

Conversation

jRiest
Copy link

@jRiest jRiest commented Oct 17, 2019

No description provided.

Currently this only handles "inherit" bindings, but it's already getting to be a fairly large change, so I wanted to break it up a bit before implementing other types of bindings.
@jRiest jRiest force-pushed the jriest/worker-bindings branch from f09f0b4 to f2015f4 Compare October 17, 2019 23:32
workers.go Outdated
OldName string
}

// serialize handles serializing the binding as part of the multipart upload format. This will be
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the rest of this comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ fixed

Copy link

@avidal avidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@patryk patryk merged commit be0b36f into cloudflare:master Oct 24, 2019
Michael9127 pushed a commit to Michael9127/cloudflare-go that referenced this pull request Oct 28, 2019
* Add support for worker bindings

Currently this only handles "inherit" bindings, but it's already getting to be a fairly large change, so I wanted to break it up a bit before implementing other types of bindings.

* Add support for Workers KV namespace bindings

* Add support for WebAssembly module worker bindings

* fixup! Add support for worker bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants